Implement CPFP fee bumping for unconfirmed transactions #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Camillarhi wants to merge 1 commit into lightningdevkit:main from Camillarhi:feat/tx-cpfp

Contributor

Camillarhi commented Sep 17, 2025 •

edited

Loading

Add Child-Pays-For-Parent functionality to allow users to accelerate pending unconfirmed transactions by creating higher-fee child spends. This provides an alternative to Replace-by-Fee bumping when direct transaction replacement is not available or desired.

Creates new transactions spending from unconfirmed UTXOs with increased fees
Specifically designed for accelerating stuck unconfirmed transactions
Miners consider combined fees of parent and child transactions
Maintains payment tracking and wallet state consistency
Includes integration tests covering various CPFP scenarios
Provides clear error handling for unsuitable or confirmed UTXOs

The feature is accessible via bump_fee_cpfp(payment_id) method.

Fixes: #22


          Implement CPFP fee bumping for unconfirmed transactions

5c9976b

Add `Child-Pays-For-Parent` functionality to allow users to accelerate
pending unconfirmed transactions by creating higher-fee child spends.
This provides an alternative to Replace-by-Fee bumping when direct
transaction replacement is not available or desired.

- Creates new transactions spending from unconfirmed UTXOs with increased fees
- Specifically designed for accelerating stuck unconfirmed transactions
- Miners consider combined fees of parent and child transactions
- Maintains payment tracking and wallet state consistency
- Includes integration tests covering various CPFP scenarios
- Provides clear error handling for unsuitable or confirmed UTXOs

The feature is accessible via `bump_fee_cpfp(payment_id)` method.

ldk-reviews-bot commented Sep 17, 2025 •

edited

Loading

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot requested a review from tnull

September 17, 2025 13:35

ldk-reviews-bot commented Sep 20, 2025

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Sep 22, 2025

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Sep 24, 2025

🔔 3rd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Sep 27, 2025

🔔 4th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Sep 29, 2025

🔔 5th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Oct 1, 2025

🔔 6th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Oct 4, 2025

🔔 7th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Oct 6, 2025

🔔 8th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Oct 8, 2025

🔔 9th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull reviewed

View reviewed changes

Collaborator

tnull left a comment

Makes sense, but I think we'll want #628 to go in first (which in turn probably now should be based on top of another PR utilizing the BDK WalletEvent) so that we have a good way to track any bumps (RBF or CPFP) across our API. Feel free to draft until then.

Contributor Author

Camillarhi commented Oct 9, 2025

Makes sense, but I think we'll want #628 to go in first (which in turn probably now should be based on top of another PR utilizing the BDK WalletEvent) so that we have a good way to track any bumps (RBF or CPFP) across our API. Feel free to draft until then.

I’ll go ahead and draft a PR that adds the event-based sync logic to update_payment_store, and we can merge that first. Then #628 can build directly on top of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet